Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tracked markers displayed with pyorerun #896

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Oct 15, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre changed the title feat: tracked markers displayed with pyorerun [RTM if tests pass] feat: tracked markers displayed with pyorerun Oct 29, 2024
@Ipuch
Copy link
Collaborator Author

Ipuch commented Oct 30, 2024

Everything worked on macOS and Linux isn't that enough ? :)

@pariterre
Copy link
Member

Everything worked on macOS and Linux isn't that enough ? :)

I restarted shrd1 for Windows twice yesterday but it failed repeatedly, not sure why though... do you think your changes could have affected this?

@Ipuch
Copy link
Collaborator Author

Ipuch commented Oct 30, 2024

Everything worked on macOS and Linux isn't that enough ? :)

I restarted shrd1 for Windows twice yesterday but it failed repeatedly, not sure why though... do you think your changes could have affected this?

Honestly no...

@pariterre pariterre changed the title [RTM if tests pass] feat: tracked markers displayed with pyorerun feat: tracked markers displayed with pyorerun Oct 30, 2024
@pariterre pariterre merged commit b7e28ff into pyomeca:master Oct 30, 2024
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants