Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add units in Points to make it readable by mokka #299

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

Ipuch
Copy link
Contributor

@Ipuch Ipuch commented Oct 20, 2023

I built a c3d with the previous guidelines but got a problem when opened it because the unit was missing.
So I added a line to provide help to users.


This change is Reviewable

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)


README.md line 511 at r1 (raw file):

# Fill it with random data
c3d['parameters']['POINT']['UNITS']['value'] = ['m']

Vicon uses "mm" as default, should we?

Copy link
Contributor Author

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pariterre)


README.md line 511 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

Vicon uses "mm" as default, should we?

This was more consistent with the random values after that bounded within 0 and 1.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit fda7b03 into pyomeca:dev Oct 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants