-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ignore CLI option to ignore certain symbol patterns #111
Comments
Hey @giampaolo, thanks for the feature request! I've got mixed feelings on this: on one hand these are false positives from a stable ABI perspective, but on the other they're strongly discouraged by CPython's API:
(link: https://docs.python.org/3/c-api/intro.html#include-files) TL;DR: I think I could be convinced here, but only if it'd be a significant refactoring challenge for |
Thank you, I appreciate it, but the refactoring is not hard per-se (it's just a mass rename). And I definitively wouldn't ask you to put the burden on your tool just because doing the refactoring on my tool is hard (it's not). =) |
Sounds good! I'll leave this open in case others have other use cases where an |
Sorry, I still could use your help. I renamed
Note: psutil on Linux has 2 extension modules,
I'm not sure why abi3audit complains about |
Hmm, random guess, but is
|
Ah yeah, based on your CI you have
This is a funny edge case 🙂 -- I'll have to see what the C ABI reference says about this! It's possible |
From https://docs.python.org/3/extending/building.html#c.PyInit_modulename:
My interpretation of this is that it's OK to have multiple |
Hello!
Since a recent upgrade of
abi3audit
, my psutil CI builds started failing because long time ago I defined some customPy*
functions which I use pretty much all over the C extension code (>200 occurrences). My take from this is thatabi3audit
does not recognize them as known cPython API symbols due to the fact that I used aPy*
prefix. Would it be possible to add an--ignore
CLI parameter in order to ignore such occurrences?E.g. in my case
python3 -m abi3audit --ignore=PyInit__psutil_posix --ignore=PyErr_SetFromOSErrnoWithSyscall ...
would serve this purpose.Thanks in advance
The text was updated successfully, but these errors were encountered: