Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_audit: relax PyInit check #112

Merged
merged 1 commit into from
Sep 30, 2024
Merged

_audit: relax PyInit check #112

merged 1 commit into from
Sep 30, 2024

Conversation

woodruffw
Copy link
Member

See discussion in #111.

CC @giampaolo

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw added the bug Something isn't working label Sep 30, 2024
@woodruffw woodruffw self-assigned this Sep 30, 2024
@woodruffw
Copy link
Member Author

Tested this with the wheels in psutils' CI and confirmed that the PyInit_ bug is gone, only the PyErr symbol (which is a TP) remains:

abi3audit --verbose ~/Downloads/wheels/psutil-6.0.1-cp*-abi3*
[16:04:06] 👎                                                                                 
           psutil-6.0.1-cp36-abi3-manylinux_2_12_i686.manylinux2010_i686.manylinux_2_17_i686.m
           anylinux2014_i686.whl: _psutil_posix.abi3.so has non-ABI3 symbols                  
           ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓                                                
           ┃ Symbol                          ┃                                                
           ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩                                                
           │ PyErr_SetFromOSErrnoWithSyscall │                                                
           └─────────────────────────────────┘                                                
           👎                                                                                 
           psutil-6.0.1-cp36-abi3-manylinux_2_12_i686.manylinux2010_i686.manylinux_2_17_i686.m
           anylinux2014_i686.whl: _psutil_linux.abi3.so has non-ABI3 symbols                  
           ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓                                                
           ┃ Symbol                          ┃                                                
           ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩                                                
           │ PyErr_SetFromOSErrnoWithSyscall │                                                
           └─────────────────────────────────┘                                                
           💁                                                                                 
           psutil-6.0.1-cp36-abi3-manylinux_2_12_i686.manylinux2010_i686.manylinux_2_17_i686.m
           anylinux2014_i686.whl: 2 extensions scanned; 0 ABI version mismatches and 2 ABI    
           violations found                                                                   
           👎                                                                                 
           psutil-6.0.1-cp36-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.manylinux_2_17_x8
           6_64.manylinux2014_x86_64.whl: _psutil_posix.abi3.so has non-ABI3 symbols          
           ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓                                                
           ┃ Symbol                          ┃                                                
           ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩                                                
           │ PyErr_SetFromOSErrnoWithSyscall │                                                
           └─────────────────────────────────┘                                                
           👎                                                                                 
           psutil-6.0.1-cp36-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.manylinux_2_17_x8
           6_64.manylinux2014_x86_64.whl: _psutil_linux.abi3.so has non-ABI3 symbols          
           ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓                                                
           ┃ Symbol                          ┃                                                
           ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩                                                
           │ PyErr_SetFromOSErrnoWithSyscall │                                                
           └─────────────────────────────────┘                                                
           💁                                                                                 
           psutil-6.0.1-cp36-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.manylinux_2_17_x8
           6_64.manylinux2014_x86_64.whl: 2 extensions scanned; 0 ABI version mismatches and 2
           ABI violations found                                                               
           👎 psutil-6.0.1-cp36-abi3-manylinux_2_17_aarch64.manylinux2014_aarch64.whl:        
           _psutil_posix.abi3.so has non-ABI3 symbols                                         
           ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓                                                
           ┃ Symbol                          ┃                                                
           ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩                                                
           │ PyErr_SetFromOSErrnoWithSyscall │                                                
           └─────────────────────────────────┘                                                
           👎 psutil-6.0.1-cp36-abi3-manylinux_2_17_aarch64.manylinux2014_aarch64.whl:        
           _psutil_linux.abi3.so has non-ABI3 symbols                                         
           ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓                                                
           ┃ Symbol                          ┃                                                
           ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩                                                
           │ PyErr_SetFromOSErrnoWithSyscall │                                                
           └─────────────────────────────────┘                                                
           💁 psutil-6.0.1-cp36-abi3-manylinux_2_17_aarch64.manylinux2014_aarch64.whl: 2      
           extensions scanned; 0 ABI version mismatches and 2 ABI violations found 

@woodruffw woodruffw merged commit 7ed45ab into main Sep 30, 2024
12 checks passed
@woodruffw woodruffw deleted the ww/relax-pyinit branch September 30, 2024 20:05
@giampaolo
Copy link

Thanks a lot for the super fast fix. Appreciate it.

@woodruffw
Copy link
Member Author

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants