Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --verbose imply --summary on the command line #127

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

nicholasjng
Copy link
Contributor

This is more in line with user expectations, and results in tables being rendered when invoking abi3audit <spec> -v, even without --summary.

--summary behavior itself is unchanged, as is the rendering algorithm.


On the other feature branch, testing on Dockerfile v3.3.1, CPython 3.8, manylinux, this results in:

$ abi3audit wheelhouse/dockerfile-3.3.1-cp38-abi3-manylinux_2_5_x86_64.manylinux1_x86_64.whl -v   
[19:55:27] 👎 dockerfile-3.3.1-cp38-abi3-manylinux_2_5_x86_64.manylinux1_x86_64.whl: dockerfile.abi3.so has non-ABI3 symbols                                                    
           ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓                                                                                                                       
           ┃ Symbol                          ┃ Version  ┃                                                                                                                       
           ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩                                                                                                                       
           │ PyDockerfile_GoIOError          │ not ABI3 │                                                                                                                       
           │ PyDockerfile_PyArg_ParseTuple_U │ not ABI3 │                                                                                                                       
           │ PyDockerfile_Command            │ not ABI3 │                                                                                                                       
           │ PyDockerfile_GoParseError       │ not ABI3 │                                                                                                                       
           │ PyDockerfile_Py_RETURN_NONE     │ not ABI3 │                                                                                                                       
           │ PyDockerfile_NewCommand         │ not ABI3 │                                                                                                                       
           └─────────────────────────────────┴──────────┘                                                                                                                       
           💁 dockerfile-3.3.1-cp38-abi3-manylinux_2_5_x86_64.manylinux1_x86_64.whl: 1 extensions scanned; 0 ABI version mismatches and 6 ABI violations found

This is more in line with user expectations, and results in tables being
rendered when invoking `abi3audit <spec> -v`, even without `--summary`.

`--summary` behavior itself is unchanged, as is the rendering algorithm.
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@woodruffw woodruffw merged commit b634cf7 into pypa:main Jan 6, 2025
12 checks passed
@nicholasjng nicholasjng deleted the verbose-implies-summary branch January 6, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants