-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conflicting classification of install #1572
Conversation
The first paragraph says the command must not be run anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! None of the commands should be run anymore. I think that this just states for the record that things still exist, but the document does not provide suggestions on how to deal with them right now. Removing one but leaving the others doesn't feel right. Not sure we'd want it in this form.
@webknjaz for all the commands in this one particular list we do not make any recommendation for an alternative solution, but the issue pointed here is that we actually do have a recommendation for So while the text in the body of the commit message is incorrect, the change itself is correct. |
@webknjaz Can we get this merged? This is a straightforward fix. I was the one to write this page and introduce this mistake. I am sure this fix is correct. |
I don't understand. Lines 21 to 26 list 4 commands as "MUST NOT be run": Lines 121 through 153 lists 25 commands as "remaining" or no recommended replacement. I'm trying to fix the one overlapping element between the two lists. I've updated the pull request description to be more specific. Please let me know if other changes are necessary to make the clarification acceptable. |
Thanks : ) |
Lines 21 to 23 state that the
install
command must not be run anymore.📚 Documentation preview 📚: https://python-packaging-user-guide--1572.org.readthedocs.build/en/1572/