-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes on runtime version access #1607
Conversation
Also redirects the obsolete single-source version guide to the updated single-source version discussion.
Seeing if we can make HTTP redirects work without an extension like https://pypi.org/project/sphinx-reredirects/ Test link for the redirect: https://python-packaging-user-guide--1607.org.readthedocs.build/en/1607/guides/single-sourcing-package-version/ Edit: the redirect is triggering, but the current relative URL isn't right. Will investigate further later this evening. |
Found a surprising CPython docs issue here: python/cpython#125018 |
@ncoghlan thanks for taking this on! I was hoping to take a stub at actually writing some content, but it doesn't look like I'm going to get to that anytime soon, so I guess this is the way. Seeing that you're repeating some of #1276, I think it would be nice to add a |
wim glenn <hey@wimglenn.com>:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing this up!
I posted a PR for the lack of semantic reference targets in the CPython docs, so assuming that review goes smoothly I may be able to fix this PR to use proper references before it gets merged: python/cpython#125027 |
@ncoghlan so I made a mistake in the suggested attribution command earlier (I've updated that comment to correct it since) and missed a chunk of the trailer in it, which is why GitHub didn't attribute that commit to wim glenn. It was supposed to be Normally, I'd suggest just putting this trailer as a |
Co-authored-by: Éric <merwok@netwok.org>
* address review comments * go back to semantic cross-references (the build will fail until the CPython PR and its backports land, but that's OK)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assorted review comments addressed. Build will currently fail, as I went back to using semantic cross-references to importlib.metadata
APIs (in anticipation of getting the stdlib docs update PR and its backports merged)
Co-Authored-By: wim glenn <hey@wimglenn.com>
@webknjaz Huh, interesting, I hadn't realised that squash merges could be disabled outright (although I can see that enabling the merge queue would do so). I'll do the full squash on the PR branch just before merge (since it messes up the comment threads if I do it beforehand) |
@ncoghlan yep, you're right. Technically that's not disabled directly but when merge queues is required for a branch, it only lets one select a single method. Overriding it is possible for admins as they'd be able to bypass the merge queues when force-merging. |
The semantic link targets are live on docs.python.org, so I'll remove the |
Given the +1's above and the lack of objections on the discuss.python.org thread, I'm going to go ahead and merge this one to give us a solid foundation for any future updates. |
Also redirects the obsolete single-source version guide to the updated single-source version discussion.
📚 Documentation preview 📚: https://python-packaging-user-guide--1607.org.readthedocs.build/en/1607/