-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pre-commit pins and fix issues #836
Open
henryiii
wants to merge
5
commits into
pypa:main
Choose a base branch
from
henryiii:henryiii/chore/update-pc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Sep 27, 2024
henryiii
commented
Sep 27, 2024
FYI, I need the mypy bump in this for the pyproject-metadata work. |
henryiii
force-pushed
the
henryiii/chore/update-pc
branch
from
October 24, 2024 05:18
c76e984
to
2a33eef
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/update-pc
branch
from
October 24, 2024 18:01
2a33eef
to
3a8e011
Compare
Rebased now that #828 is in. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps things like Ruff and MyPy and applied the simplest (minimal change) fixes for the issues. Longer term, asserts could remove some of the type ignores.