Fix setuptools_wheel fixture
#4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/build/lib/... directories Based on the test introduced in b4d3e83, we can see that when none of `PRE_BUILT_SETUPTOOLS_SDIST` or `PRE_BUILT_SETUPTOOLS_WHEEL` is set, the `setuptools_wheel` fixture keeps recursively creating `build/lib/build/lib/...` directories which slows down the tests and creates a huge amount of unnecessary files. This change tries to target that.
abravalheri
force-pushed
the
fix-setuptools_wheel-fixture
branch
from
06726bb to
14ce350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Based on the test introduced in b4d3e83, we can see that when none of
PRE_BUILT_SETUPTOOLS_SDISTorPRE_BUILT_SETUPTOOLS_WHEELis set, thesetuptools_wheelfixture keeps recursively creatingbuild/lib/build/lib/...directories which slows down the tests and creates a huge amount of unnecessary files.This change tries to avoid that by building simultaneously
sdist/wheel.Closes
Pull Request Checklist
newsfragments/.(See documentation for details)