-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statically alias distutils-stubs to setuptools._distutils #4704
Open
Avasam
wants to merge
2
commits into
pypa:main
Choose a base branch
from
Avasam:statically-alias-distutils-stubs-to-setuptools._distutils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Statically alias distutils-stubs to setuptools._distutils #4704
Avasam
wants to merge
2
commits into
pypa:main
from
Avasam:statically-alias-distutils-stubs-to-setuptools._distutils
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2024
Avasam
commented
Oct 25, 2024
Avasam
force-pushed
the
statically-alias-distutils-stubs-to-setuptools._distutils
branch
5 times, most recently
from
October 25, 2024 20:33
1733d12
to
f950ecc
Compare
Avasam
force-pushed
the
statically-alias-distutils-stubs-to-setuptools._distutils
branch
4 times, most recently
from
November 24, 2024 22:53
7085815
to
e66c7ae
Compare
I've added a comment at the top of geenrated files to make it clear that they are generated and how to regenerate them. |
Avasam
commented
Nov 25, 2024
Avasam
commented
Nov 25, 2024
Avasam
force-pushed
the
statically-alias-distutils-stubs-to-setuptools._distutils
branch
from
December 30, 2024 23:46
4ed7925
to
5b9d787
Compare
Avasam
force-pushed
the
statically-alias-distutils-stubs-to-setuptools._distutils
branch
from
December 30, 2024 23:51
5b9d787
to
0f98b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #4689
This is an alternative to #4691. This makes type-checkers and editors see
distutils
as basically an alias tosetuptools.
Advantage:
Disadvantage:
Pull Request Checklist
newsfragments/
. (no need until this is shipped with setuptools)(See documentation for details)