Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ldcxxshared contains ccache #4749

Closed
wants to merge 1 commit into from
Closed

Conversation

trim21
Copy link

@trim21 trim21 commented Nov 13, 2024

Summary of changes

LDCXXSHARED will be "ccache /usr/bin/c++ -shared" if it's compiled with ccache, and it will fail linker

I'm not sure how to test this...

Closes #4748

Pull Request Checklist

@trim21 trim21 marked this pull request as ready for review November 13, 2024 12:13
@abravalheri
Copy link
Contributor

Hi @trim21, thank you very much for investigating this.

Could you please provide the feedback and PR directly to the https://github.com/pypa/distutils repository please?

The setuptools/_distutils folder is not directly modified in the pypa/setuptools repository, instead we periodically merge from pypa/distutils (this practice is documented in https://setuptools.pypa.io/en/latest/development/developer-guide.html#code-conventions-and-other-practices).

@trim21
Copy link
Author

trim21 commented Nov 13, 2024

Oh, sorry. I find this file by debugger, didn't notice the file path

@trim21 trim21 closed this Nov 13, 2024
@abravalheri
Copy link
Contributor

That is not a problem at all, just some internal organisation. Thank you very much for working on this.

@trim21
Copy link
Author

trim21 commented Nov 13, 2024

pypa/distutils#313

@trim21 trim21 deleted the ccache-fix branch November 13, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] can't link c++ so if python is compiled with ccache since 72.2.0
2 participants