-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[self tests] test_pkginfo_returns_no_metadata fails against pkginfo 1.11.0 #1116
Comments
As I'm looking through the links, I'm finding launchpad to be unusable. Some requests take many tens of seconds, others fail with 503 Service Unavailable. As a result, I've been unable to review the code changes or find a changelog. I can see from the bug report that the intention was to turn the exceptions into warnings (and let clients like twine capture those warnings and handle them however). So if I assume that twine wishes to retain the current behavior as captured by the failing test, I'll draft a change to transform the warnings. |
I'm no longer confident that we want twine to retain the current behavior (fail if the metadata version is not yet recognized). Since pkginfo was asked to be lenient, perhaps twine should be lenient also, allowing the warning to be emitted, but proceeding if possible. |
* Prepare for v5.1.1 * Re-render changelog. * Pin against pkginfo 1.11 until the fix for #1116 can be merged, unblocking release. --------- Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Is there an existing issue for this?
What keywords did you use to search existing issues?
test_pkginfo_returns_no_metadata
What operating system are you using?
Linux
If you selected 'Other', describe your Operating System here
No response
What version of Python are you running?
How did you install twine? Did you use your operating system's package manager or pip or something else?
git clone https://github.com/pypa/twine
What version of twine do you have installed (include the complete output)
Which package repository are you using?
https://pypi.org/
Please describe the issue that you are experiencing
test_pkginfo_returns_no_metadata
test fails with:Please list the steps required to reproduce this behaviour
python3 -m tox -e py
Anything else you'd like to mention?
pkginfo
1.11.0
changed behavior if it deals with unknown metadata version:https://bugs.launchpad.net/pkginfo/+bug/2058697
https://bazaar.launchpad.net/~tseaver/pkginfo/trunk/revision/235
The text was updated successfully, but these errors were encountered: