-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIRES wavelengths #272
HIRES wavelengths #272
Conversation
And development files. Make me put in a |
this is a reminder to myself to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm "requesting changes" so that we can discuss the following three points:
- I'm a little worried about how you're importing stuff from local files by adding the local directory to the path. I give you a way around this that feels cleaner, but let me know what you think.
- I'd prefer that we not overwrite the original slits file in your test.
- I'm wondering if there's a better/cleaner directory structure for the pypeit files that are used for the
reduce
tests vs. those that are needed for more bespoke vet/unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Testing for pypeit/PypeIt#1628