Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIRES wavelengths #272

Merged
merged 36 commits into from
Aug 13, 2023
Merged

HIRES wavelengths #272

merged 36 commits into from
Aug 13, 2023

Conversation

profxj
Copy link
Contributor

@profxj profxj commented Jul 10, 2023

Testing for pypeit/PypeIt#1628

@profxj profxj requested a review from kbwestfall July 10, 2023 16:02
@profxj
Copy link
Contributor Author

profxj commented Jul 10, 2023

And development files.

Make me put in a redo_slits test on a multislit spectrograph
as a vet test, before merging.

@profxj
Copy link
Contributor Author

profxj commented Jul 20, 2023

this is a reminder to myself to remove the setups list
in test_setups.py before merging

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm "requesting changes" so that we can discuss the following three points:

  • I'm a little worried about how you're importing stuff from local files by adding the local directory to the path. I give you a way around this that feels cleaner, but let me know what you think.
  • I'd prefer that we not overwrite the original slits file in your test.
  • I'm wondering if there's a better/cleaner directory structure for the pypeit files that are used for the reduce tests vs. those that are needed for more bespoke vet/unit tests.

pypeit_files/shane_kast_red_redoslit_600_5000_d46.pypeit Outdated Show resolved Hide resolved
test_scripts/pypeit_tests.py Show resolved Hide resolved
test_scripts/setups.py Outdated Show resolved Hide resolved
test_scripts/setups.py Show resolved Hide resolved
test_scripts/test_setups.py Outdated Show resolved Hide resolved
unit_tests/test_metadata.py Show resolved Hide resolved
vet_tests/test_echelles.py Outdated Show resolved Hide resolved
vet_tests/test_echelles.py Outdated Show resolved Hide resolved
vet_tests/test_wavelengths.py Show resolved Hide resolved
vet_tests/test_wavelengths.py Show resolved Hide resolved
Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@profxj profxj merged commit 90c6300 into develop Aug 13, 2023
@profxj profxj deleted the hires_wmko_23 branch August 13, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants