Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collate_1d testing for new funtionality #280

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

badpandabear
Copy link
Collaborator

Add '--chk_version when testingpypeit_collate_1d` to make sure that functionality is executed.

Update vet_tests/test_scripts.py::test_collate_1d to test chk_version as a .collate1d parameter file option and that the --chk_version command line flag overrides the parameter file.

This should not be merged until pypeit/PypeIt#1649 is merged in the main PypeIt repo.

Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@badpandabear badpandabear merged commit ee53b5f into develop Aug 15, 2023
@badpandabear badpandabear deleted the collate_updates branch August 15, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants