Skip to content

Commit

Permalink
addressing PR comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
jhennawi committed Jul 19, 2024
1 parent 58391cd commit 13f0dc4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions pypeit/images/pypeitimage.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ class PypeItImage(datamodel.DataContainer):
:class:`~pypeit.images.rawimage.RawImage.process`.
"""

# TODO These docs are confusing. The __init__ method needs to be documented just as it is for
# every other class that we have written in PypeIt, i.e. the arguments all need to be documented. They are not
# documented here and instead we have the odd Args documentation above.
version = '1.3.0'
"""Datamodel version number"""

Expand Down Expand Up @@ -161,6 +164,7 @@ def from_pypeitimage(cls, pypeitImage):
# Done
return self

# TODO This init method needs proper docs, which includes every optional argument. See my comment above.
def __init__(self, image, ivar=None, nimg=None, amp_img=None, det_img=None, rn2img=None,
base_var=None, img_scale=None, fullmask=None, detector=None, spat_flexure=None,
filename=None, PYP_SPEC=None, units=None, exptime=None, noise_floor=None,
Expand Down
4 changes: 2 additions & 2 deletions pypeit/images/rawimage.py
Original file line number Diff line number Diff line change
Expand Up @@ -676,9 +676,9 @@ def process(self, par, bpm=None, scattlight=None, flatimages=None, bias=None, sl
exptime=self.exptime,
noise_floor=self.par['noise_floor'],
shot_noise=self.par['shot_noise'],
bpm=_bpm.astype(bool))
bpm=_bpm.astype(bool),
filename=self.filename)

pypeitImage.filename = self.filename
pypeitImage.rawheadlist = self.headarr
pypeitImage.process_steps = [key for key in self.steps.keys() if self.steps[key]]

Expand Down

0 comments on commit 13f0dc4

Please sign in to comment.