Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rms_threshold #1651

Closed
profxj opened this issue Aug 11, 2023 · 2 comments
Closed

Refactor rms_threshold #1651

profxj opened this issue Aug 11, 2023 · 2 comments
Assignees
@debora-pe

Comments

@profxj
Copy link
Collaborator

profxj commented Aug 11, 2023

As a follow-on to #1628,
we need to refactor rms_threshold to be relative to the FWHM.

@debora-pe -- I suggest we do this as part of the LRIS wavelengths PR
that you are working on. The main annoyance will be to update the
values throughout the spectrograph files (and a few PypeIt files of the DevSuite).
@debora-pe
Copy link
Collaborator

PR #1672 is addressing it

@debora-pe
Copy link
Collaborator

Addressed. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@debora-pe debora-pe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@profxj @debora-pe