Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - arxiv soln #1632

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Hotfix - arxiv soln #1632

merged 3 commits into from
Jul 17, 2023

Conversation

rcooke-ast
Copy link
Collaborator

As suggested by @kbwestfall - this approach unifies the caching of user-generated wavelength solutions.

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for the quick change!

@kbwestfall kbwestfall requested a review from tbowers7 July 13, 2023 19:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #1632 (36af1e6) into develop (2045e8b) will increase coverage by 0.00%.
The diff coverage is 20.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##           develop    #1632   +/-   ##
========================================
  Coverage    39.94%   39.94%           
========================================
  Files          190      190           
  Lines        42805    42803    -2     
========================================
  Hits         17098    17098           
+ Misses       25707    25705    -2     
Impacted Files Coverage Δ
pypeit/scripts/arxiv_solution.py 0.00% <0.00%> (ø)
pypeit/core/wavecal/wvutils.py 45.34% <14.28%> (-0.94%) ⬇️
pypeit/core/gui/identify.py 8.59% <50.00%> (+0.03%) ⬆️

Copy link
Collaborator

@tbowers7 tbowers7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for unifying this -- and for adding the arxiv_solution script a while ago. Useful feature!

@rcooke-ast rcooke-ast merged commit 670eacb into develop Jul 17, 2023
25 checks passed
@rcooke-ast rcooke-ast deleted the hotfix_arxiv_soln branch July 17, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants