Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air2vac correction for XShooter standards #1633

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Air2vac correction for XShooter standards #1633

merged 3 commits into from
Jul 28, 2023

Conversation

freddavies
Copy link
Collaborator

@freddavies freddavies commented Jul 16, 2023

Finally addressing (at least one part of) #941, as the issue has become even more obvious for the UVB arm of XShooter.

Might be worth checking whether any of the other standard files also need this fix...

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #1633 (1c0944f) into develop (6b2b85c) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##           develop    #1633   +/-   ##
========================================
  Coverage    39.89%   39.89%           
========================================
  Files          190      190           
  Lines        42875    42877    +2     
========================================
+ Hits         17105    17106    +1     
- Misses       25770    25771    +1     
Impacted Files Coverage Δ
pypeit/core/flux_calib.py 31.92% <50.00%> (+0.06%) ⬆️

Copy link
Collaborator

@jhennawi jhennawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @freddavies can you please modify the README file at:

~/PypeIt/pypeit/data/standards/xshooter

To explicitly note that the data stored in the files is in air. Also, does the reference say anything about it?

Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@freddavies
Copy link
Collaborator Author

freddavies commented Jul 20, 2023

README updated.

Also, does the reference say anything about it?

Unfortunately it does not say anything explicitly, but one can guess it from the fact that they are using the ESO pipeline to reduce the data, which spits out air wavelengths by default. Otherwise the only other evidence is the much better agreement between the model and the (PypeIt-reduced) data in the absorption line cores...

@freddavies freddavies merged commit d5d06c7 into develop Jul 28, 2023
25 checks passed
@rcooke-ast rcooke-ast deleted the xsh_std_waves branch September 10, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants