-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Air2vac correction for XShooter standards #1633
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #1633 +/- ##
========================================
Coverage 39.89% 39.89%
========================================
Files 190 190
Lines 42875 42877 +2
========================================
+ Hits 17105 17106 +1
- Misses 25770 25771 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @freddavies can you please modify the README file at:
~/PypeIt/pypeit/data/standards/xshooter
To explicitly note that the data stored in the files is in air. Also, does the reference say anything about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
README updated.
Unfortunately it does not say anything explicitly, but one can guess it from the fact that they are using the ESO pipeline to reduce the data, which spits out air wavelengths by default. Otherwise the only other evidence is the much better agreement between the model and the (PypeIt-reduced) data in the absorption line cores... |
Finally addressing (at least one part of) #941, as the issue has become even more obvious for the UVB arm of XShooter.
Might be worth checking whether any of the other standard files also need this fix...