Collate 1d updates #1649
Merged
Collate 1d updates #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #1649 +/- ##
========================================
Coverage 40.98% 40.99%
========================================
Files 189 189
Lines 43055 43092 +37
========================================
+ Hits 17646 17664 +18
- Misses 25409 25428 +19
|
profxj
approved these changes
Aug 13, 2023
pypeit/core/collate.py
Outdated
| """Build a list of SourceObjects from a list of spec1d files. There will be one SourceObject per | ||
| SpecObj in the resulting list (i.e. no combining or collating is done by this method). | ||
|
|
||
| Args: | ||
| spec1d_files (list of str): List of spec1d filenames | ||
| spec1d_files (list of :obj:`pypeit.specobjs.SpecObjs`): List of SpecObjs objects to build from. |
debora-pe
approved these changes
Aug 14, 2023
pypeit/scripts/collate_1d.py
Outdated
| - **missing_archive_msgs** (:obj:`list`): A list of messages | ||
| explaining why some source objects were excluded. | ||
|
|
||
| **excluded_messages** (:obj:`list`): A list of messages explaining why some source objects were excluded. |
There was a problem hiding this comment.
I think here it's missing the - for the bullet list
|
dev-suite run: The failed unit tests were later fixed by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to pypeit_collate_1d for ADAP 2019. Changes include: