Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration group hotfix #1824

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Calibration group hotfix #1824

merged 4 commits into from
Jul 22, 2024

Conversation

kbwestfall
Copy link
Collaborator

Addresses #1823

The logic used to identify frames with calibration groups assumed there would always be at least one frame that had a single (numeric) calibration group. This fixes a failure caused when the pypeit file only contains frames that are set to all calibration groups.

@kbwestfall kbwestfall mentioned this pull request Jul 1, 2024
Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boy we should refactor this someday :)

Copy link
Collaborator

@debora-pe debora-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.48%. Comparing base (b9dd4ce) to head (911e256).

Files Patch % Lines
pypeit/metadata.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1824   +/-   ##
========================================
  Coverage    38.48%   38.48%           
========================================
  Files          207      207           
  Lines        48151    48153    +2     
========================================
+ Hits         18532    18533    +1     
- Misses       29619    29620    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbwestfall kbwestfall changed the base branch from release to develop July 17, 2024 15:12
@kbwestfall kbwestfall merged commit 9c7bb98 into develop Jul 22, 2024
23 checks passed
@kbwestfall kbwestfall deleted the calib_only branch July 22, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants