Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for empty 2D wavecal solution in HDU extension of WaveCalib file #1825

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

kbwestfall
Copy link
Collaborator

As titled.

Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it!

Copy link
Collaborator

@debora-pe debora-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kbwestfall

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.32673% with 33 lines in your changes missing coverage. Please review.

Project coverage is 38.48%. Comparing base (8ec2351) to head (b9baa54).
Report is 91 commits behind head on release.

Files Patch % Lines
pypeit/utils.py 55.00% 18 Missing ⚠️
pypeit/core/findobj_skymask.py 79.31% 6 Missing ⚠️
pypeit/cache.py 66.66% 2 Missing ⚠️
pypeit/find_objects.py 83.33% 2 Missing ⚠️
pypeit/scripts/show_2dspec.py 0.00% 2 Missing ⚠️
pypeit/core/skysub.py 50.00% 1 Missing ⚠️
pypeit/core/wavecal/autoid.py 0.00% 1 Missing ⚠️
pypeit/scripts/identify.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1825      +/-   ##
===========================================
- Coverage    38.53%   38.48%   -0.05%     
===========================================
  Files          206      207       +1     
  Lines        47992    48151     +159     
===========================================
+ Hits         18494    18532      +38     
- Misses       29498    29619     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbwestfall kbwestfall changed the base branch from release to develop July 17, 2024 15:12
@kbwestfall kbwestfall merged commit b9dd4ce into develop Jul 22, 2024
23 checks passed
@kbwestfall kbwestfall deleted the empty_2dwvcal branch July 22, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants