Adds support for numpy>=2.0.0
#1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User metrics figure
…t is not in a git repo
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1829 +/- ##
===========================================
- Coverage 38.53% 38.48% -0.05%
===========================================
Files 206 207 +1
Lines 47992 48151 +159
===========================================
+ Hits 18494 18532 +38
- Misses 29498 29619 +121 ☔ View full report in Codecov by Sentry. |
badpandabear
approved these changes
Jul 11, 2024
profxj
approved these changes
Jul 15, 2024
| xsize = slit_righ - slit_left | ||
| #nsamp = np.ceil(np.median(xsize)) # JFH Changed 07-07-19 | ||
| nsamp = np.ceil(xsize.max()) | ||
| if nobj == 0: |
There was a problem hiding this comment.
doesn't look like numpy issues, so I assume some other
bits and pieces slipped in. which is fine
|
Tests pass, except for the one expected failure. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accommodates changes in numpy version 2.0.
According to this, these changes should not affect use by numpy <2.0.0, so I haven't included an increment in the dependency version requirements yet. But we should likely warn users to be aware of this change and encourage them to upgrade numpy once this is released.
I'll re-run the dev-suite on this and post the results, but we should expect some
bok_bcfailures that we need to fix before tagging a new release.