Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows installation problem (Issue #1634) #1831

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Conversation

badpandabear
Copy link
Collaborator

As described in issue 1634 code added to support OpenMP was failing on windows because gcc was not installed. Through testing I found that installing gcc was not sufficient to deal with this because setup tools would always use the Microsoft Visual Studio compiler when building the extension.

It turns out the extension_helpers package, already used by PypeIt, had similar code to test for and use OpenMP that worked on windows. So I updated bspline/setup_package.py and pypeit_c_enabled to use that code instead. I also updated the installation docs to provide more information on how to install under Windows and how to enable OpenMP on Macs. I also referenced Windows Subsystem for Linux as an alternative for running under Windows.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 38.51%. Comparing base (9e19d4c) to head (46dfe13).
Report is 404 commits behind head on develop.

Files with missing lines Patch % Lines
pypeit/bspline/setup_package.py 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1831      +/-   ##
===========================================
+ Coverage    38.49%   38.51%   +0.01%     
===========================================
  Files          207      207              
  Lines        48171    48151      -20     
===========================================
  Hits         18545    18545              
+ Misses       29626    29606      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/installing.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@tepickering tepickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noted a couple changes to be done, most importantly update the version of gcc from 12 to 14. or just specify the homebrew gcc specifically. everything else looks good. thanks for the quick work!

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the detailed update to the windows installation instructions!

@kbwestfall kbwestfall merged commit f048fef into develop Jul 23, 2024
23 checks passed
@kbwestfall kbwestfall deleted the windows_install branch July 23, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants