-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows installation problem (Issue #1634) #1831
Conversation
…avoid windows install problem.
…n the developers slack.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1831 +/- ##
===========================================
+ Coverage 38.49% 38.51% +0.01%
===========================================
Files 207 207
Lines 48171 48151 -20
===========================================
Hits 18545 18545
+ Misses 29626 29606 -20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i noted a couple changes to be done, most importantly update the version of gcc
from 12 to 14. or just specify the homebrew gcc specifically. everything else looks good. thanks for the quick work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the detailed update to the windows installation instructions!
As described in issue 1634 code added to support OpenMP was failing on windows because gcc was not installed. Through testing I found that installing gcc was not sufficient to deal with this because setup tools would always use the Microsoft Visual Studio compiler when building the extension.
It turns out the extension_helpers package, already used by PypeIt, had similar code to test for and use OpenMP that worked on windows. So I updated
bspline/setup_package.py
andpypeit_c_enabled
to use that code instead. I also updated the installation docs to provide more information on how to install under Windows and how to enable OpenMP on Macs. I also referenced Windows Subsystem for Linux as an alternative for running under Windows.