Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: pyqt6 version and ginga connection timeout #1836

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

kbwestfall
Copy link
Collaborator

As titled. Note this is going straight to release.

Copy link
Collaborator

@jhennawi jhennawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jhennawi
Copy link
Collaborator

jhennawi commented Aug 5, 2024

Will you also pull this into develop when approved?

@kbwestfall
Copy link
Collaborator Author

Will you also pull this into develop when approved?

Yes, but it will also require a PR.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.48%. Comparing base (8ec2351) to head (ef373e4).
Report is 91 commits behind head on release.

Files Patch % Lines
pypeit/display/display.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1836      +/-   ##
===========================================
- Coverage    38.53%   38.48%   -0.06%     
===========================================
  Files          206      207       +1     
  Lines        47992    48106     +114     
===========================================
+ Hits         18494    18512      +18     
- Misses       29498    29594      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@debora-pe debora-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question

setup.cfg Outdated Show resolved Hide resolved
@kbwestfall kbwestfall merged commit 35e103c into release Aug 26, 2024
23 checks passed
@kbwestfall kbwestfall deleted the ginga_iter branch August 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants