Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix display #1837

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Hotfix display #1837

merged 2 commits into from
Aug 12, 2024

Conversation

rcooke-ast
Copy link
Collaborator

Simple hotfix that deals with the case when trc_name is not set

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.22%. Comparing base (c2dca65) to head (844c2a8).

Files Patch % Lines
pypeit/display/display.py 0.00% 2 Missing ⚠️
pypeit/alignframe.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1837      +/-   ##
===========================================
- Coverage    38.22%   38.22%   -0.01%     
===========================================
  Files          208      208              
  Lines        48357    48358       +1     
===========================================
- Hits         18486    18483       -3     
- Misses       29871    29875       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Please add a change comment in the docs.

@rcooke-ast
Copy link
Collaborator Author

Good call - done!

@kbwestfall kbwestfall merged commit a4f1fe0 into develop Aug 12, 2024
23 checks passed
@kbwestfall kbwestfall deleted the hotfix_align branch August 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants