Keck/KCWI BH3 support #1847
Merged
Keck/KCWI BH3 support #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/releases/1.16.1dev.rst
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1847 +/- ##
===========================================
- Coverage 38.09% 38.09% -0.01%
===========================================
Files 211 211
Lines 49000 49002 +2
===========================================
Hits 18665 18665
- Misses 30335 30337 +2 ☔ View full report in Codecov by Sentry. |
|
PS - I realized this morning that, in order for this mode to be "supported" we need an example dataset to test in the dev-suite. Do we have one? |
|
Yep - I'm working on it :-) |
|
dev suite passes, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per a request on the User's Slack, this PR adds support for the Keck/KCWI BH3 grating. See the wavelength solution attached.
