Introducing an option for the user to decide on simplifying GADM shapes #1138
Conversation
|
|
… into simplify_gadm
…th into simplify_gadm
There was a problem hiding this comment.
Hello @SermishaNarayana :)
Thank for the contribution and the PR is ready to merge.
Unfortunately git history is not the best; for future PRs, it is a great idea if you update your main and clean it.
Moreover, please fix merge conflicts into the README; I see the documenter is leading to some weird effects to be fixed in the future.
config.default.yaml
Outdated
| @@ -106,6 +106,7 @@ cluster_options: | |||
|
|
|||
| build_shape_options: | |||
| gadm_layer_id: 1 # GADM level area used for the gadm_shapes. Codes are country-dependent but roughly: 0: country, 1: region/county-like, 2: municipality-like | |||
| simplify_gadm: false # When true, shape polygons are simplified else no | |||
There was a problem hiding this comment.
By default, let's enable the simplification. This on average speeds up computation and is desirable
|
Hello @SermishaNarayana :D |
Hi @davide-f ! Apologies, I somehow missed the comment on the merge conflicts with READme earlier. I have resolved it now. |
|
Thanks! @SermishaNarayana :D merging |
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yamlanddoc/requirements.txt.config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.