Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adds fixed env ci #1183

Merged
merged 9 commits into from
Nov 21, 2024
Merged

ci: adds fixed env ci #1183

merged 9 commits into from
Nov 21, 2024

Conversation

lkstrp
Copy link
Contributor

@lkstrp lkstrp commented Nov 13, 2024

Adds pinned env ci and runs test on pinned env instead, as implemented in pypsa-eur.
Removes envs/environment.fixed.yaml and adds envs/<os>-pinned.yaml instead which are automatically updated.
This is useful for the devcontainer implementation by @drifter089 and @GbotemiB

See PyPSA/pypsa-eur#1379

  • updates fixed env ci to
    • Create env for each os (ubuntu, windows, linux). They are not compatible across systems.
    • Runs weekly/ on manual trigger/ env changes
  • Run tests on fixed env instead
    • This way we don't test dependency changes in the ci and only test the code or if data retrieval fails.
    • Dependency updates are checked in the weekly trigger above.
    • As pypsa-eur is not a library, there is no big reason to keep the dependency constraints wide. And they are still via the normal environment file

@lkstrp
Copy link
Contributor Author

lkstrp commented Nov 13, 2024

Tests will fail since the env files need to be created initially. But it looks like they are not running through anyways?

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks and this seems a great contribution!
This simplifies a lot the maintenance of the model indeed

I'd also recommend adding here a release note also to summarize the great three contributions you proposed :) you can find it in doc/release_notes.rst.
Many thanks :D

.github/workflows/update-pinned-env.yml Outdated Show resolved Hide resolved
@lkstrp
Copy link
Contributor Author

lkstrp commented Nov 14, 2024

Thank you and no worries! I added release notes for all three PRs.

The Tests CI fails right now, so this needs another look once this one is merged

@lkstrp
Copy link
Contributor Author

lkstrp commented Nov 19, 2024

I added a fix to trigger the PR only by changes in env file on master branch.
The tests will still fail, since the pinned env version is not created yet. So this needs to be merged first.

@davide-f
Copy link
Member

Understandable, great contribution @lkstrp :D Merging :)

@davide-f davide-f merged commit 0eac2ea into pypsa-meets-earth:main Nov 21, 2024
3 of 7 checks passed
@ekatef ekatef mentioned this pull request Dec 4, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants