-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electricity distribution grid #1221
Add electricity distribution grid #1221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yerbol-akhmetov, looks like great and nicely implemented contribution. My only concern relates to the naming conventions. Could you please check it?
Otherwise, it appears to be an advancement of PyPSA-Eur approach 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @ekatef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yerbol-akhmetov :D
Thanks for the contribution!
To me the contribution looks great and is tested in the CI as the technology is added by default.
The log does not have warnings related to the CI and contribution does not affect the rest of the code.
If katia is satisfied, on my side we can merge this :D
I'd say that not only CI is working but the implementation is also perfectly correct and well-elaborated 😄 Great work @yerbol-akhmetov! Absolutely agree that we must merge it. @yerbol-akhmetov would you mind to resolve the merge conflict? Then, the PR is ready to go 🚀 |
Merged 😄 Thanks a lot for the great contribution @yerbol-akhmetov!! |
Changes proposed in this Pull Request
Good day. This PR aims to add electricity distribution grid to sector network. The PR is inspired by implementation of distribution grid in PyPSA-Eur. I think this will be useful. What do you think @davide-f ?
Checklist
config.default.yaml
andconfig.tutorial.yaml
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.