Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add electricity distribution grid #1221

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

yerbol-akhmetov
Copy link
Collaborator

@yerbol-akhmetov yerbol-akhmetov commented Dec 4, 2024

Changes proposed in this Pull Request

Good day. This PR aims to add electricity distribution grid to sector network. The PR is inspired by implementation of distribution grid in PyPSA-Eur. I think this will be useful. What do you think @davide-f ?

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@yerbol-akhmetov yerbol-akhmetov marked this pull request as ready for review December 5, 2024 07:15
Copy link
Member

@ekatef ekatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yerbol-akhmetov, looks like great and nicely implemented contribution. My only concern relates to the naming conventions. Could you please check it?

Otherwise, it appears to be an advancement of PyPSA-Eur approach 🙂

scripts/prepare_sector_network.py Show resolved Hide resolved
scripts/prepare_sector_network.py Show resolved Hide resolved
scripts/prepare_sector_network.py Show resolved Hide resolved
Copy link
Collaborator Author

@yerbol-akhmetov yerbol-akhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @ekatef

scripts/prepare_sector_network.py Show resolved Hide resolved
scripts/prepare_sector_network.py Show resolved Hide resolved
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yerbol-akhmetov :D
Thanks for the contribution!
To me the contribution looks great and is tested in the CI as the technology is added by default.
The log does not have warnings related to the CI and contribution does not affect the rest of the code.
If katia is satisfied, on my side we can merge this :D

@ekatef
Copy link
Member

ekatef commented Dec 10, 2024

Hello @yerbol-akhmetov :D Thanks for the contribution! To me the contribution looks great and is tested in the CI as the technology is added by default. The log does not have warnings related to the CI and contribution does not affect the rest of the code. If katia is satisfied, on my side we can merge this :D

I'd say that not only CI is working but the implementation is also perfectly correct and well-elaborated 😄 Great work @yerbol-akhmetov!

Absolutely agree that we must merge it. @yerbol-akhmetov would you mind to resolve the merge conflict? Then, the PR is ready to go 🚀

@ekatef ekatef merged commit deb9198 into pypsa-meets-earth:main Dec 12, 2024
6 checks passed
@ekatef
Copy link
Member

ekatef commented Dec 12, 2024

Merged 😄 Thanks a lot for the great contribution @yerbol-akhmetov!!

@yerbol-akhmetov yerbol-akhmetov deleted the add_low_voltage branch December 12, 2024 13:47
@Eric-Nitschke Eric-Nitschke mentioned this pull request Jan 2, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants