Custom Airport Data #1235
Merged
Custom Airport Data #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super @GbotemiB! Thank you for the implementation. On the first glance, looks perfectly reasonable. Would be great to discuss the details tomorrow, also with the experts on sector-coupled modeling |
| @@ -0,0 +1,2 @@ | |||
| ,ident,type,airport_size_nr,name,y,x,elevation_ft,continent,country,iso_region,municipality,scheduled_service,iata_code,length_ft,width_ft,surface,lighted,closed,Total_airport_size_nr,fraction | |||
| 0,5A8,medium_airport,1,Aleknagik / New Airport,59.2826004028,-158.617996216,66.0,,US,US-AK,Aleknagik,yes,WKK,2040.0,80.0,GRVL-DIRT-F,0.0,0.0,633,0.001579778830963665 | |||
There was a problem hiding this comment.
Thanks, @GbotemiB. Was the second line given as a example?
There was a problem hiding this comment.
Yeah you are right, the second line is supposed to be as an example.
|
Good work @GbotemiB . Thank you for implementing that. Sadly,I could not find passenger information for all airports globally. But for now, this is a good solution for countries who have such more realistic data for consumption. I will merge now. |
|
@GbotemiB @Eddy-JV @yerbol-akhmetov perfect 😄 Great work!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1225 .
Changes proposed in this Pull Request
This PR aims to address the use of custom data for airports data. This PR is a follow-up from #1225
Checklist
envs/environment.yamlanddoc/requirements.txt.config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.