Harmonise folder structure for workflow outputs #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davide-f
reviewed
Dec 23, 2024
| unsd_path = ( | ||
| os.path.dirname(snakemake.input["energy_totals_base"]) + "/demand/unsd/data/" | ||
| os.path.dirname(snakemake.input["transactions_path"]) + "/demand/unsd/data/" |
There was a problem hiding this comment.
Hello!
Apologies, the review of this PR may have been left in drafts.
The whole PR sounds great to me but I'm a bit in doubt about this line.
The rule build_base_energy_totals creates such folder with the target files here loaded.
I believe it would be advisable to add an output to the build base rule and an input here with the directory.
That should avoid the confusion and this inner hidden dependencies.
What do you think?
davide-f
approved these changes
Dec 24, 2024
Super 🙂 I think yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
PR address TODOs in Snakemake related to placing the outputs into
resourcesinstead ofdata. It has also required some changes in other Snakemake rules and inside the scripts.Checklist
envs/environment.yamlanddoc/requirements.txt.config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.