-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests #1270
base: main
Are you sure you want to change the base?
Add integration tests #1270
Conversation
The implementation is currently very rough, and the primary application is to provide a tool to check consistency of the current workflow. Testing for the tutorial test case, has given satisfactory results for "physical" load, as well as solar and offwind potential. However, onwind potential has increased ater simplification and clustering by about ~30% (22363710.2206911 for |
Great! :D I'm wondering if this would be greatly placed in a test folder or potentially a validator procedure. what do you think? |
Totally agree that ideally it should be added to the tests and just satisfied under all the conditions. Currently, it looks like currently we may have some flaws should be fixed first. In particular, it relates to the renewable potential which must be investigated better. The relevant part is weighting procedure in PyPSA which may probably need some correction coefficients. I'm transforming this PR into a draft for now 🙂 |
The PR adds a check on propagation along the workflow of the values which must be invariants according to conservation laws.
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.