Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not compute powerplants from ppm if replace option is used #1281

Merged

Conversation

yerbol-akhmetov
Copy link
Collaborator

@yerbol-akhmetov yerbol-akhmetov commented Jan 4, 2025

Changes proposed in this Pull Request

Good day. The following changes aim to reduce unwanted computation if replace option is selected in the config while using custom powerplants data. It helps to avoid long computation of powerplants from powerplantmatching for some large countries.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @yerbol-akhmetov :D Many thanks.
Contribution is pretty neat!
I'm adding few minor comments and merge it right away, unless you prefer otherwise :)
In particular:

  1. the release note will be moved under new contributions [very minor thing]
  2. I'll update the format of the custom_powerplants to the latest version. The reason being that when replace is selected, the new dataframe will have the format of custom_powerplants. Thus it is advisable to update.

As they are minor things, I'll quickly do and merge it :) Many thanks for the contribution!

@davide-f
Copy link
Member

davide-f commented Jan 4, 2025

I'd merge as CI passes

@davide-f davide-f merged commit a0971d5 into pypsa-meets-earth:main Jan 4, 2025
6 checks passed
@yerbol-akhmetov
Copy link
Collaborator Author

Great @yerbol-akhmetov :D Many thanks. Contribution is pretty neat! I'm adding few minor comments and merge it right away, unless you prefer otherwise :) In particular:

  1. the release note will be moved under new contributions [very minor thing]
  2. I'll update the format of the custom_powerplants to the latest version. The reason being that when replace is selected, the new dataframe will have the format of custom_powerplants. Thus it is advisable to update.

As they are minor things, I'll quickly do and merge it :) Many thanks for the contribution!

Thanks, @davide-f.

@yerbol-akhmetov yerbol-akhmetov deleted the custom_powerplants_fix branch January 5, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants