Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated config entry #1288

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

doneachh
Copy link
Contributor

@doneachh doneachh commented Jan 10, 2025

Closes # (if applicable).

Changes proposed in this Pull Request

In the config file was an entry "hydrogen_underground_storage", which wasnt used at all - we use "[sector][hydrogen][underground_storage]". I removed it!

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@doneachh
Copy link
Contributor Author

doneachh commented Jan 10, 2025

@ekatef I removed an entry in the config file ("hydrogen_underground_storage"), which wasnt used at all as we use "[sector][hydrogen][underground_storage]". Can you review and merge it / also merge it to your config PR? :)

@doneachh
Copy link
Contributor Author

I'm also unsure about the entries gadm_layer_id and gadm_level, but they are both used. @ekatef do you know the difference between those?

@ekatef
Copy link
Member

ekatef commented Jan 10, 2025

Hello @doneachh, that is an amazing idea to clean-up the config! Thanks a lot for addressing hydrogen_underground_storage.

My feeling is that it would facilitate implementation of the modeling approach for the config. The point is we can easily have some side effects from interactions between some config parameters. If you see any way to improve it, that would be very much appreciated.

I'm also unsure about the entries gadm_layer_id and gadm_level, but they are both used. @ekatef do you know the difference between those?

My understanding is that it has been a difference between the power and sector-coupled parts. For now, it looks like a duplication. Feel free to address it 🙂

If you have any other ideas to improve structure of the config, feel free to go ahead and ping me once you'd be satisfied with the result 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants