Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Colorsplasher - Not creating viewfilters for a shared parameter #2466

Closed
5 tasks done
dsellam opened this issue Nov 25, 2024 · 6 comments · Fixed by #2514
Closed
5 tasks done

[Bug]: Colorsplasher - Not creating viewfilters for a shared parameter #2466

dsellam opened this issue Nov 25, 2024 · 6 comments · Fixed by #2514
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Tools Issues related to pyRevit commands [subsystem]

Comments

@dsellam
Copy link

dsellam commented Nov 25, 2024

✈ Pre-Flight checks

  • I don't have SentinelOne antivirus installed (see above for the solution)
  • I have searched in the issues (open and closed) but couldn't find a similar issue
  • I have searched in the pyRevit Forum for similar issues
  • I already followed the installation troubleshooting guide thoroughly
  • I am using the latest pyRevit Version

🐞 Describe the bug

Hello, Trying to create View filters on Masses , with values of a shared parameters (text values), I have the following error message :

Error message :
"Viewfilters were not created. The selected parameter is not exposed by Revit and rules cannot be created"

image

⌨ Error/Debug Message

No response

♻️ To Reproduce

No response

⏲️ Expected behavior

View filters created in the view settings

🖥️ Hardware and Software Setup (please complete the following information)

==> Registered Clones (full git repos)
==> Registered Clones (deployed from archive/image)
==> Attachments
Unknown | Product: "Autodesk Revit 2025" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2025\pyRevit.addin"
Unknown | Product: "Autodesk Revit 2024" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2024\pyRevit.addin"
Unknown | Product: "2023.1.1" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2023\pyRevit.addin"
==> Installed Extensions
(private)
==> Extension Sources - Default
https://github.com/pyrevitlabs/pyRevit/raw/master/extensions/extensions.json
==> Extension Sources - Additional
==> Installed Revits
Autodesk Revit 2025 | Version: 25.0.2.419 | Build: 20240307_1300(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2025\"
Autodesk Revit 2024 | Version: 24.3.0.13 | Build: 20240912_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2024\"
2023.1.1 | Version: 23.1.10.4 | Build: 20221122_1550(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2023\"
==> Running Revit Instances
Error: La référence d'objet n'est pas définie à une instance d'un objet.
Run with "--debug" option to see debug messages

Additional context

I was wondering if this could come from specific caracters in the filter values ? That's why I copied paste the parameter window.

@dsellam dsellam added the Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] label Nov 25, 2024
@dsellam dsellam changed the title [Bug]: Colorsplasher - [Bug]: Colorsplasher - Not xreating viewfilters for a shared parameter Nov 25, 2024
@dsellam dsellam changed the title [Bug]: Colorsplasher - Not xreating viewfilters for a shared parameter [Bug]: Colorsplasher - Not creating viewfilters for a shared parameter Nov 25, 2024
@sanzoghenzo sanzoghenzo added the Tools Issues related to pyRevit commands [subsystem] label Dec 27, 2024
@jmcouffin
Copy link
Contributor

Can you try the latest wip.
It contains a revamped color splasher

@jmcouffin
Copy link
Contributor

jmcouffin commented Jan 13, 2025

Can you try the latest wip. It contains a revamped color splasher

The latest WIP did not solve it, it is due to the name of the filter containing

DEBUG [ColorSplasher] Exception value: name cannot include prohibited characters, such as "{, }, [, ], |, ;, less-than sign, greater-than sign, ?, `, ~". 

@jmcouffin
Copy link
Contributor

fixed by #2514
unwanted character in filtername being ':'
I am glad I took the time to implement proper debugging 😄

@jmcouffin
Copy link
Contributor

and @dsellam your explanaition was great to resolve it.

@dsellam
Copy link
Author

dsellam commented Jan 14, 2025

awesome ! Is it included in the next WIP version of pyrevit to test it ?

@jmcouffin
Copy link
Contributor

if you follow the link to the PR #2514
You will find the latest wip in the thread
answer is: YES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Tools Issues related to pyRevit commands [subsystem]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants