-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show unicode in toasts #2493
Conversation
I should have tried it inside pyRevit before submitting it 😅 I simplified some things and made the function signature compatible with The problem now is... IronPython's ElementTree doesn't seem to work with unicode, so I'm back at square one 😓 @dosymep I saw that you wrote a comment about the dependency, do you think that using an UWP component will break things? |
yep |
Would it be better to use
Because I just ported the go code of the previous |
oh okay :) |
I am so close... but I don't know how to solve it! I switched to string templates to avoid unwanted etree string escaping; Now the Test Button in DevTools shows a "??" instead of the rocket, but if I copy the script from the debug log and paste into powershell with I tried to encode/decode the strings, but no combination works... As always, ChatGPT is full of shit. BTW, I also tried using Windows.UI.Notification, but obviously it needed an assembly that is not referenced, and I'm too lazy to try to add it (where? should it be pyRevitLabs.Runtime?) and recompile 😅 EDIT: oh, python 2.7 subprocess doesn't work with unicode on windows.... |
I would help you, but for some reason notifications don't work on my version of the operating system |
I tried to add the patch for windows subprocess, it shows the correct toast but Since this isn't an high priority task, I'm giving up on this and remove the issue form the pyrevit 5 RC milestone, if someone else wants to pick it up it's more than welcome to do so! |
closes #2484
Title and message with unicode chars (I tried emojis) work, actions and sounds don't.
Now that I think of it, we could use the
Microsoft.Toolkit.Uwp.Notifications
.NET package for that instead of relying on a powershell script...