-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make
command should look for README.md/README.markdown
#10
Comments
+1... but I think there should be a way to specify the actual file to use. See also https://github.com/github/gollum/blob/master/README.md for other extensions that may be of interest (including additional extensions for Markdown). |
I made a quick patch that implements the idea from my previous comment. Does it look like a sensible approach to you? |
Yeah, that works OK. I guess I'd like to have the command be smarter by default than to require a custom |
@fpoirotte, what happened with this? Are you going to (at least) make a pull request for this feature, or better yet, also add some sort of detection? BTW, if you do add detection by default, I'd personally prefer the exact opposite from @saltybeagle's suggested order. Why? Because of Github - they use that order, so if Pyrus_Developer uses it, then the README file would be completely ignored in the presense of README.md, whereas IMO, it would be better to enable one README file for Github (the ".md" one), and another one (the one without extension) for Pyrus_Developer. But of course, regardless of the implemented automatic order, if the feature of a custom README from scanoptions.php is there, I'd also be happy with the suggested order. |
Right now the
make
command only scans for aREADME
file. Most repositories useREADME.md
orREADME.markdown
and it would be convenient to check for those files in addition toREADME
.Suggested check order:
The text was updated successfully, but these errors were encountered: