Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix weights plotting #533

Merged
merged 2 commits into from
Jul 14, 2023
Merged

BUG: fix weights plotting #533

merged 2 commits into from
Jul 14, 2023

Conversation

martinfleis
Copy link
Member

Closes #525

We currently do not have any test suite for plotting, so I am not adding any tests here. Will add some as part of the weights refactoring which will include plotting refactoring as well.

@jGaboardi jGaboardi added plotting rough edge Something that's not a bug, but that gets in the way of "it just works." and removed plotting labels Jul 14, 2023
@jGaboardi
Copy link
Member

Failure:

FAILED libpysal/weights/tests/test_weights.py::TestW::test_to_sparse - AttributeError: module 'scipy.sparse' has no attribute '_arrays'

@martinfleis
Copy link
Member Author

@jGaboardi that is the one I fixed in parallel in #532

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #533 (e44debc) into main (d925cc3) will increase coverage by 0.1%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #533     +/-   ##
=======================================
+ Coverage   79.9%   79.9%   +0.1%     
=======================================
  Files        113     113             
  Lines      13135   13135             
=======================================
+ Hits       10491   10500      +9     
+ Misses      2644    2635      -9     
Impacted Files Coverage Δ
libpysal/weights/weights.py 83.2% <0.0%> (ø)

... and 1 file with indirect coverage changes

@jGaboardi jGaboardi merged commit a2e3902 into pysal:main Jul 14, 2023
8 of 9 checks passed
@martinfleis martinfleis deleted the fix_plot branch July 14, 2023 15:31
@jGaboardi
Copy link
Member

re: plotting tests

I've had success with matplotlib's decorator – image_comparison

We should probably open a specific issue for this.

@martinfleis
Copy link
Member Author

I think we have some issue like this in splot?

@jGaboardi
Copy link
Member

xref pysal/splot#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rough edge Something that's not a bug, but that gets in the way of "it just works."
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W.plot() raises TypeError due to indexing a GeoDataFrame with a dict
2 participants