ENH: ensure lag_spatial is compatible with both W and Graph

[martinfleis]

Ensures that when downstream packages (like splot pysal/splot#184) use lag_spatial when a Graph is given, the actual computation produces correct lag. This will avoid silent introduction of bugs when using Graph as scipy does not raise but produces different output.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.4%. Comparing base (d52d684) to head (4b9970d).
Report is 3 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #765   +/-   ##
=====================================
  Coverage   85.4%   85.4%           
=====================================
  Files        150     150           
  Lines      15989   15989           
=====================================
  Hits       13655   13655           
  Misses      2334    2334           

Files with missing lines	Coverage Δ
libpysal/weights/spatial_lag.py	92.9% <100.0%> (ø)

[knaaptime]

i think i would support doing a bugfix release with this change

[martinfleis]

Yeah, we could do one with this and #760 but we'll need to backport those commits. Do you want me to do that?

[knaaptime]

im game

[martinfleis]

im game

had to google what that means 🙃

[knaaptime]

😬 sorry. i vote we do it

[martinfleis]

The release notes action didn't get what I was doing but the patch release is out https://github.com/pysal/libpysal/releases/tag/v4.12.1