Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unecessary try/finally: in _multicall #277

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unecessary try/finally: in _multicall #277

wants to merge 2 commits into from

Commits on Jun 7, 2020

  1. Remove useless try in _multicall 

    In Python 3, every raisable thing inherits from BaseException, so the
`except BaseException` in the code already handles every possible exit.
So we can reduce the indentation and the slight overhead of `try`.

Diff better viewed with `git diff -w`.
    @bluetech
    bluetech committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    fbc79e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. merge from mainline

    @RonnyPfannschmidt
    RonnyPfannschmidt committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    a0dfd7f View commit details
    Browse the repository at this point in the history