Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test coverage for weird case of plugin with multiple impls of same spec #446

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wahuneke
Copy link
Contributor

These tests are attempting to find @RonnyPfannschmidt 's theoretical issue described in issue #431 . Conversation in 431 is ongoing. This PR is here for reference. It is a DRAFT.

NOTE: these tests currently pass. They do not detect any new issues.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, those tests verify that my assessment from just/only looking at the code was wrong and now we have a demonstration of the correctness for those cases

@wahuneke wahuneke marked this pull request as ready for review September 23, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants