Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases to improve coverage stat #452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wahuneke
Copy link
Contributor

@wahuneke wahuneke commented Oct 3, 2023

No description provided.

@wahuneke
Copy link
Contributor Author

wahuneke commented Oct 3, 2023

I'm not sure why it is unable to run and update the coverage stats. Perhaps this is a known issue to someone else here on the project....

In any case, my local runs showed coverage improving. For the precise improvement amount (coverage before and after) I'd need to see the codecov.io report. For now, let's just say: this PR fills in some gaps but one or two still remain (e.g. coverage for pypy-only branch)

@bluetech
Copy link
Member

@wahuneke Can you rebase? I think maybe now the coverage will be shown better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants