Add type annotations for backend/base.py #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philpep
reviewed
Jul 21, 2023
philpep
reviewed
Jul 21, 2023
philpep
approved these changes
Jul 21, 2023
|
Merged with minor modification (no need to re-type variables in Thanks! We now have a strict mypy configuration for typed code https://github.com/pytest-dev/pytest-testinfra/blob/main/mypy.ini . So I think we can gradually add types from low-level code up to all code. However I think some part of the code must be simplified to make adding types easier (refactoring & use some dataclasses). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To start with #619.
@ssbarnea could you please review?
I don't know how to configure
mypyto check one module with different rules. If that is possible, we can lintbackend/base.pymore strictly (more changes will be needed).