Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend list of valid suffixes for systemd units #740

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

CarstenGrohmann
Copy link
Contributor

The old implementation limits the usage of SystemdService.is_valid() to .service units. This implementation allows checking all types of unit files with is_valid() (systemd-analyze verify <unitname.suffix>).

@CarstenGrohmann CarstenGrohmann force-pushed the extend_systemd_unit_suffixes branch 3 times, most recently from 20e014e to c708268 Compare October 9, 2023 06:18
The old implementation limits the usage of SystemdService.is_valid() to
".service" units. This implementation allows checking all types of unit
files with is_valid() (systemd-analyze verify <unitname.suffix>).
@philpep philpep added the bug This issue/PR relates to a bug. label Nov 13, 2023
@philpep philpep merged commit b54a79e into pytest-dev:main Nov 13, 2023
7 checks passed
@philpep
Copy link
Contributor

philpep commented Nov 13, 2023

Merged, thanks!

@CarstenGrohmann CarstenGrohmann deleted the extend_systemd_unit_suffixes branch November 14, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants