feat(contract_manager): script for EVM feeds contract deployment #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
ali-bahjati
force-pushed
the
contract-mngr/new-deploymnt-script
branch
3 times, most recently
from
06fdc31
to
aafb26b
Compare
ali-bahjati
force-pushed
the
contract-mngr/new-deploymnt-script
branch
from
aafb26b
to
f27ff01
Compare
ali-bahjati
commented
Jan 29, 2024
| @@ -404,7 +404,7 @@ export class EvmEntropyContract extends Storable { | |||
| return { | |||
| chain: this.chain.getId(), | |||
| address: this.address, | |||
| type: EvmPriceFeedContract.type, | |||
| type: EvmEntropyContract.type, | |||
There was a problem hiding this comment.
it was a bug in json serialization of entropy contracts
ali-bahjati
commented
Jan 29, 2024
ali-bahjati
commented
Jan 29, 2024
| @@ -44,18 +44,18 @@ const parser = yargs(hideBin(process.argv)) | |||
| }, | |||
| }); | |||
|
|
|||
| async function run_if_not_cached( | |||
| cache_key: string, | |||
| async function runIfNotCached( | |||
There was a problem hiding this comment.
format the naming style
ali-bahjati
commented
Jan 29, 2024
|
|
||
| if (config.type === "stable") { | ||
| console.log(`Syncing mainnet guardian sets for ${chain.getId()}...`); | ||
| // TODO: Add a way to pass gas configs to this |
There was a problem hiding this comment.
Since this is a generic method I can't easily add the gas options to it. Something to refactor later in the future.
This change adds a script to replace truffle deployment scripts. This gives us more control and flexibility over the deployment process.
ali-bahjati
force-pushed
the
contract-mngr/new-deploymnt-script
branch
from
f27ff01
to
5f8ebfb
Compare
0xfirefist
reviewed
Jan 30, 2024
| @@ -598,7 +598,7 @@ export class EvmPriceFeedContract extends PriceFeedContract { | |||
| pythContract.methods.updatePriceFeeds(priceFeedUpdateData); | |||
| const gasEstiamte = await transactionObject.estimateGas({ | |||
0xfirefist
reviewed
Jan 30, 2024
| artifactName: string, | ||
| deployArgs: any[] // eslint-disable-line @typescript-eslint/no-explicit-any | ||
| ): Promise<string> { | ||
| const cache = existsSync(CACHE_FILE) |
There was a problem hiding this comment.
Can we use runIfNotCached here?
There was a problem hiding this comment.
Yeah it's a good idea. Let me do it in a separate PR (because this one is already very big)
0xfirefist
reviewed
Jan 30, 2024
m30m
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a script to replace truffle deployment scripts. This gives us more control and flexibility over the deployment process.