Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(target_chains/sui): update sui js packages #1340

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

ali-bahjati
Copy link
Collaborator

Reopening #1294 as Github wasn't smart enough to pick up the rebase.

Upgraded to 0.49.1 which was fully backward incompatible 😭
Some getter functions (like getExecutionStatusError) were removed so replaced them with their internal logic
Upgraded typescript version when needed.
Removed batch attestation support
The typesystem got a lot stricter and had to ignore some errors for now. Otherwise, there would be lots of code for type narrowing.

Left to do:

  • change the sdk to create the new price feed if it doesn't exist instead of throwing error

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 4:11pm
xc-admin-frontend ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 4:11pm

@ali-bahjati ali-bahjati merged commit 736a202 into main Mar 1, 2024
4 of 6 checks passed
@ali-bahjati ali-bahjati deleted the sui-updates branch March 1, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants