Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(staking): improve feedback #1999

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

cprussin
Copy link
Collaborator

@cprussin cprussin commented Oct 7, 2024

This PR adds better feedback to the staking app. Included are:

  • Better error messages
  • Toasts on success / failure (failure toasts only show where there isn't a modal to display the error message)
  • Buttons go into a spinner state when isLoading is true

Copy link

vercel bot commented Oct 7, 2024

@cprussin is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 1:22am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 1:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
proposals ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 1:22am

This PR adds better feedback to the staking app.  Included are:

- Better error messages
- Toasts on success / failure (failure toasts only show where there isn't a
  modal to display the error message)
- Buttons go into a spinner state when isLoading is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant