Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subspace Identification (IB) routines #169

Open
atisharma opened this issue Feb 14, 2022 · 2 comments
Open

Subspace Identification (IB) routines #169

atisharma opened this issue Feb 14, 2022 · 2 comments

Comments

@atisharma
Copy link

I'm working on wrapping the subspace ID routines IB01AD, IB01BD, IB01CD, IB03AD, IB03BD.

I have IB01AD apparently working (though untested so far, and with some uncouth assumptions about the size of working arrays).
I'm unfamiliar with fortran, wrapping it in python and slycot, so please could someone review what I've done so far? Then I can fix any problems before I work on the other routines.

You can see the work at https://github.com/atisharma/Slycot/tree/identification (on a new branch). I will make a pull request if that is preferred.

@bnavigator
Copy link
Collaborator

Hi,

sorry for not getting back to you earlier. Work on adding these wrappers is much appreciated. Please open a pull request (instructions similar to #153 (comment)), as it is easer to review and we can see if it builds in the CI. It doesn't have to be perfect at the first commit, we can work it out over time.

@atisharma
Copy link
Author

Thanks. I have some other things in the queue first, but will return to this and open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants