Fix numpy go-to-definition by taking it off autoimport list for this case #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Oct 1, 2023
There was a problem hiding this comment.
Nice improvement @smacke!
I left some minor suggestions for you, otherwise looks good to me.
ccordoba12
changed the title
|
Thanks for the suggestions! Just pushed an update that uses them. |
ccordoba12
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Looks good to me now, thanks @smacke!
I'll wait a couple of days to see if someone else wants to chime in, otherwise I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
numpyis in the autoimport list, I think go to definition doesn't use the pure static strategy of jedi'sgotoand sees that, e.g.,numpy.oneshas__module__set tonumpyand uses that, while the static strategy correctly sees thatonesis defined innumpy.core.numeric. To fix, in this PR we take everything off the jedi autoimport list before usinggotofor GTD, and we restore it once we're done.Test plan: added a unit test that passes with this PR and fails without this PR.