-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ujson with orjson #591
base: develop
Are you sure you want to change the base?
Conversation
It seems everything is here too, thanks @valrus and @rumpelsepp! I'll release 1.12.0 first and then 2.0.0 a couple of weeks after that with this improvement. |
@valrus @ccordoba12 Are there any existing tests to benchmark the |
@simon-liebehenschel I'm not aware of any tests covering memory usage, but I might take a stab at writing one. Can you provide any pointers to the issue(s) you're concerned about? |
But I do not know if it will have any impact on |
This PR is a small update to @rumpelsepp's here: #579
It just points the
python-lsp-jsonrpc
dependency at the branch I have PR'd at python-lsp/python-lsp-jsonrpc#29, to demonstrate the tests pass.